Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: run flaky tests in Travis #27015

Closed
wants to merge 1 commit into from
Closed

build: run flaky tests in Travis #27015

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Mar 30, 2019 •
edited
Loading

Skipping flaky tests in CI is an anti-pattern that should be avoided,
as we do in our own CI. Failing flaky tests don’t need to be blockers
for a green CI result, but they should be run and reported somehow.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3109/pipeline

@richardlau richardlau mentioned this pull request Mar 30, 2019
Closed
2 tasks
@richardlau richardlau added the build Issues and PRs related to build files or the CI. label Mar 30, 2019
@refack refack added the blocked PRs that are blocked by other issues or PRs. label Mar 30, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 31, 2019 •
edited
Loading

@refack can you please elaborate in what way this is blocked and by what?

@addaleax
build: run flaky tests in Travis
44b1fb7 
Skipping flaky tests in CI is an anti-pattern that should be avoided,
as we do in our ownCI. Failing flaky tests don’t need to be blockers
for a green CI result, but they should be run and reported *somehow*.
@addaleax addaleax removed the blocked PRs that are blocked by other issues or PRs. label Apr 3, 2019
@addaleax
Copy link
Member Author

addaleax commented Apr 3, 2019

Rebased, lite CI: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3152/pipeline

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 4, 2019
@Trott Trott added blocked PRs that are blocked by other issues or PRs. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 5, 2019
@Trott
Copy link
Member

Trott commented Apr 5, 2019

Hi, everyone! Sorry to be mysterious, but please leave the blocked label on for another 72 hours. I know we're supposed to provide reasons for things like that and I'm not doing that here. If you could indulge me on this anyway, it would be greatly appreciated.

@Trott Trott mentioned this pull request Apr 9, 2019
Closed
2 tasks
@addaleax
Copy link
Member Author

addaleax commented Apr 9, 2019

This PR will continue as #27158. I will not engage in that thread but still stand behind this change.

@addaleax addaleax closed this Apr 9, 2019
@addaleax addaleax deleted the travis-dont-skip branch April 9, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
blocked PRs that are blocked by other issues or PRs. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @nodejs-github-bot @BridgeAR @Trott @lpinca @richardlau @refack