Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: remove env: node in eslint config for lib files #27082

Closed
wants to merge 2 commits into from

Commits on Apr 4, 2019

  1. lib: remove env: node in eslint config for lib files

    This patch removes the redundant `require-globals` custom
    eslint rule by removing `env: node` in the eslint config
    and whitelist the globals that can be accessed in native
    modules instead of black listing them. This makes sense
    for our `lib/` files because here we are creating the
    Node.js environment instead of running in a normal user
    land Node.js environment.
    joyeecheung committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    451f6ba View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2019

  1. Configuration menu
    Copy the full SHA
    bd865ac View commit details
    Browse the repository at this point in the history