Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test-spawn-cmd-named-pipe #2770

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions test/parallel/test-spawn-cmd-named-pipe.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
'use strict';
const common = require('../common');
const assert = require('assert');

// This test is intended for Windows only
if (!common.isWindows) {
console.log('1..0 # Skipped: this test is Windows-specific.');
return;
}

if (!process.argv[2]) {
// parent
const net = require('net');
const spawn = require('child_process').spawn;
const path = require('path');

const pipeNamePrefix = path.basename(__filename) + '.' + process.pid;
const stdinPipeName = '\\\\.\\pipe\\' + pipeNamePrefix + '.stdin';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it it matters much, but in libuv we use \\\\?\\pipe prefix. IIRC @piscisaureus suggested the change at some point in time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. I assume that the \\\\?\\pipe syntax is to support extended-length names. I don't think it should matter much here as the pipe name is hardcoded.

const stdoutPipeName = '\\\\.\\pipe\\' + pipeNamePrefix + '.stdout';

const stdinPipeServer = net.createServer(function(c) {
c.on('end', common.mustCall(function() {
}));
c.end('hello');
});
stdinPipeServer.listen(stdinPipeName);

const output = [];

const stdoutPipeServer = net.createServer(function(c) {
c.on('data', function(x) {
output.push(x);
});
c.on('end', common.mustCall(function() {
assert.strictEqual(output.join(''), 'hello');
}));
});
stdoutPipeServer.listen(stdoutPipeName);

const comspec = process.env['comspec'];
if (!comspec || comspec.length === 0) {
assert.fail('Failed to get COMSPEC');
}

const args = ['/c', process.execPath, __filename, 'child',
'<', stdinPipeName, '>', stdoutPipeName];

const child = spawn(comspec, args);

child.on('exit', common.mustCall(function(exitCode) {
stdinPipeServer.close();
stdoutPipeServer.close();
assert.strictEqual(exitCode, 0);
}));
} else {
// child
process.stdin.pipe(process.stdout);
}