-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test-spawn-cmd-named-pipe #2770
Closed
orangemocha
wants to merge
1
commit into
nodejs:master
from
JaneaSystems:orangemocha-testCmdNamedPipe
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
|
||
// This test is intended for Windows only | ||
if (!common.isWindows) { | ||
console.log('1..0 # Skipped: this test is Windows-specific.'); | ||
return; | ||
} | ||
|
||
if (!process.argv[2]) { | ||
// parent | ||
const net = require('net'); | ||
const spawn = require('child_process').spawn; | ||
const path = require('path'); | ||
|
||
const pipeNamePrefix = path.basename(__filename) + '.' + process.pid; | ||
const stdinPipeName = '\\\\.\\pipe\\' + pipeNamePrefix + '.stdin'; | ||
const stdoutPipeName = '\\\\.\\pipe\\' + pipeNamePrefix + '.stdout'; | ||
|
||
const stdinPipeServer = net.createServer(function(c) { | ||
c.on('end', common.mustCall(function() { | ||
})); | ||
c.end('hello'); | ||
}); | ||
stdinPipeServer.listen(stdinPipeName); | ||
|
||
const output = []; | ||
|
||
const stdoutPipeServer = net.createServer(function(c) { | ||
c.on('data', function(x) { | ||
output.push(x); | ||
}); | ||
c.on('end', common.mustCall(function() { | ||
assert.strictEqual(output.join(''), 'hello'); | ||
})); | ||
}); | ||
stdoutPipeServer.listen(stdoutPipeName); | ||
|
||
const comspec = process.env['comspec']; | ||
if (!comspec || comspec.length === 0) { | ||
assert.fail('Failed to get COMSPEC'); | ||
} | ||
|
||
const args = ['/c', process.execPath, __filename, 'child', | ||
'<', stdinPipeName, '>', stdoutPipeName]; | ||
|
||
const child = spawn(comspec, args); | ||
|
||
child.on('exit', common.mustCall(function(exitCode) { | ||
stdinPipeServer.close(); | ||
stdoutPipeServer.close(); | ||
assert.strictEqual(exitCode, 0); | ||
})); | ||
} else { | ||
// child | ||
process.stdin.pipe(process.stdout); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it it matters much, but in libuv we use
\\\\?\\pipe
prefix. IIRC @piscisaureus suggested the change at some point in time.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. I assume that the
\\\\?\\pipe
syntax is to support extended-length names. I don't think it should matter much here as the pipe name is hardcoded.