Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update babel-eslint to 10.0.2 #28266

Closed
wants to merge 1 commit into from
Closed

tools: update babel-eslint to 10.0.2 #28266

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Jun 17, 2019 •
edited
Loading

Update babel-eslint to 10.0.2 by running tools/update-babel-eslint.sh.

Refs: https://github.com/babel/babel-eslint/releases/tag/v10.0.2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 17, 2019
@ZYSzys
Copy link
Member Author

ZYSzys commented Jun 17, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3688/

BridgeAR
BridgeAR approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

This seems to add a few files that were missing before 👍 (even though it seems like we did not require them).

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 17, 2019
trivikr
trivikr approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Trott
Trott approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

Trott
Trott approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-rubber-stamp LGTM. The change set is manageable so I was able to actually review it. :-D

@ZYSzys
Copy link
Member Author

ZYSzys commented Jun 20, 2019

Landed in d698983.

@ZYSzys ZYSzys closed this Jun 20, 2019
ZYSzys added a commit to zys-contrib/node that referenced this pull request Jun 20, 2019
@ZYSzys
tools: update babel-eslint to 10.0.2
d698983 
PR-URL: nodejs#28266
Refs: https://github.com/babel/babel-eslint/releases/tag/v10.0.2
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@ZYSzys ZYSzys deleted the babel-eslint branch June 20, 2019 05:56
targos pushed a commit that referenced this pull request Jul 2, 2019
@ZYSzys @targos
tools: update babel-eslint to 10.0.2
dd53e6a 
PR-URL: #28266
Refs: https://github.com/babel/babel-eslint/releases/tag/v10.0.2
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ZYSzys @fhinkel @Trott @cjihrig @BridgeAR @trivikr @nodejs-github-bot