http2: allow passing FileHandle to respondWithFD #29876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
addaleax
added
the
semver-minor
5 tasks
lpinca
reviewed
Oct 7, 2019
lpinca
approved these changes
Oct 7, 2019
cjihrig
approved these changes
Oct 7, 2019
jasnell
approved these changes
Oct 7, 2019
JungMinu
approved these changes
Oct 8, 2019
addaleax
added
the
author ready
Fishrock123
reviewed
Oct 8, 2019
| @@ -2523,7 +2524,10 @@ class ServerHttp2Stream extends Http2Stream { | |||
| this[kState].flags |= STREAM_FLAGS_HAS_TRAILERS; | |||
| } | |||
|
|
|||
| validateNumber(fd, 'fd'); | |||
| if (fd instanceof fsPromisesInternal.FileHandle) | |||
There was a problem hiding this comment.
isn't instanceof a bit slow? Maybe this world be better if the checks were the other way around?
There was a problem hiding this comment.
This seems to make sense if we want to promote the use of `fs.promises`, although it’s not strictly necessary.
addaleax
force-pushed
the
http2-filehandle
branch
from
cf02001
to
3c91a7e
Compare
BridgeAR
approved these changes
Oct 9, 2019
BridgeAR
reviewed
Oct 9, 2019
|
Landed in 0ff4a55 |
addaleax
added a commit
that referenced
this pull request
Oct 9, 2019
This seems to make sense if we want to promote the use of `fs.promises`, although it’s not strictly necessary. PR-URL: #29876 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to make sense if we want to promote the use
of
fs.promises, although it’s not strictly necessary.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes