From 87aac3fd7180842e5a62a42450e9950258b2e57a Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Wed, 6 Nov 2019 12:35:56 +0100 Subject: [PATCH] Revert "test: test configure ninja" This reverts commit 85dd9e8333f227dcdcbe86ae45f239a2b5cef030. `make test` should never change the current set of `configure` flags. Refs: https://github.com/nodejs/node/pull/30033 --- Makefile | 2 +- test/tools/{test_js2c.py => test-js2c.py} | 0 test/tools/test_configure.py | 29 ----------------------- 3 files changed, 1 insertion(+), 30 deletions(-) rename test/tools/{test_js2c.py => test-js2c.py} (100%) delete mode 100644 test/tools/test_configure.py diff --git a/Makefile b/Makefile index d46b4a0c18a3d6..8d4e6bbe6474b9 100644 --- a/Makefile +++ b/Makefile @@ -300,7 +300,7 @@ jstest: build-addons build-js-native-api-tests build-node-api-tests ## Runs addo .PHONY: tooltest tooltest: - @$(PYTHON) -m unittest discover -s ./test/tools + @$(PYTHON) test/tools/test-js2c.py .PHONY: coverage-run-js coverage-run-js: diff --git a/test/tools/test_js2c.py b/test/tools/test-js2c.py similarity index 100% rename from test/tools/test_js2c.py rename to test/tools/test-js2c.py diff --git a/test/tools/test_configure.py b/test/tools/test_configure.py deleted file mode 100644 index c4e65192c9b3d1..00000000000000 --- a/test/tools/test_configure.py +++ /dev/null @@ -1,29 +0,0 @@ -import sys -import os -import unittest -import subprocess - - -class ConfigureTests(unittest.TestCase): - def setUp(self): - self.working_dir = os.path.abspath( - os.path.join( - os.path.dirname(__file__), - '..', '..' - ) - ) - - def test_ninja(self): - subprocess.check_call( - './configure --ninja', - cwd=self.working_dir, - shell=True, - stdout=subprocess.PIPE, - stderr=subprocess.PIPE - ) - - -if (__name__ == '__main__' and - sys.platform in ['linux', 'linux2', 'darwin', 'cygwin']): - - unittest.main()