From ef40ada0aec52b8085ed00e9ad41bf4e27105f35 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Jos=C3=A9=20Arboleda?= <soyjuanarbol@gmail.com>
Date: Sun, 12 Jan 2020 20:33:39 -0500
Subject: [PATCH 1/3] test: remove unused param on net stream test

---
 test/parallel/test-net-stream.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/parallel/test-net-stream.js b/test/parallel/test-net-stream.js
index 8e996dd58a7ef6..7ea45f458e0779 100644
--- a/test/parallel/test-net-stream.js
+++ b/test/parallel/test-net-stream.js
@@ -47,7 +47,7 @@ const buf = Buffer.alloc(SIZE, 'a');
 const server = net.createServer(function(socket) {
   socket.setNoDelay();
 
-  socket.on('error', function(err) {
+  socket.on('error', function() {
     socket.destroy();
   }).on('close', function() {
     server.close();

From a792b961773920739adaa1ed7c86012725573ce3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Jos=C3=A9=20Arboleda?= <soyjuanarbol@gmail.com>
Date: Sun, 12 Jan 2020 21:21:13 -0500
Subject: [PATCH 2/3] doc,lib,test: 'maxConnections' event on net server

---
 doc/api/net.md                                   | 8 ++++++++
 lib/net.js                                       | 1 +
 test/parallel/test-net-server-max-connections.js | 1 +
 3 files changed, 10 insertions(+)

diff --git a/doc/api/net.md b/doc/api/net.md
index 13bcd60cf48e1c..40a0720c3a58ac 100644
--- a/doc/api/net.md
+++ b/doc/api/net.md
@@ -92,6 +92,13 @@ added: v0.1.90
 Emitted when a new connection is made. `socket` is an instance of
 `net.Socket`.
 
+### Event: `'maxConnections'`
+<!-- YAML
+added: REPLACEME
+-->
+
+Emitted when the server has reached his connection limit defined in [`server.maxConnections`][].
+
 ### Event: `'error'`
 <!-- YAML
 added: v0.1.90
@@ -1251,6 +1258,7 @@ Returns `true` if input is a version 6 IP address, otherwise returns `false`.
 [`server.listen(handle)`]: #net_server_listen_handle_backlog_callback
 [`server.listen(options)`]: #net_server_listen_options_callback
 [`server.listen(path)`]: #net_server_listen_path_backlog_callback
+[`server.maxConnections`]: #net_server_maxconnections
 [`socket(7)`]: http://man7.org/linux/man-pages/man7/socket.7.html
 [`socket.connect()`]: #net_socket_connect
 [`socket.connect(options)`]: #net_socket_connect_options_connectlistener
diff --git a/lib/net.js b/lib/net.js
index 11dd4bc900ef9b..866ce0716e6b33 100644
--- a/lib/net.js
+++ b/lib/net.js
@@ -1535,6 +1535,7 @@ function onconnection(err, clientHandle) {
   }
 
   if (self.maxConnections && self._connections >= self.maxConnections) {
+    self.emit('maxConnections');
     clientHandle.close();
     return;
   }
diff --git a/test/parallel/test-net-server-max-connections.js b/test/parallel/test-net-server-max-connections.js
index 705c99b7b9737a..a443789de48801 100644
--- a/test/parallel/test-net-server-max-connections.js
+++ b/test/parallel/test-net-server-max-connections.js
@@ -44,6 +44,7 @@ server.listen(0, function() {
 
 server.maxConnections = N / 2;
 
+server.on('maxConnections', common.mustCall(N / 2));
 
 function makeConnection(index) {
   const c = net.createConnection(server.address().port);

From 27a022d5f1caeca7157d729470da246faf1cfa81 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Jos=C3=A9=20Arboleda?= <soyjuanarbol@gmail.com>
Date: Tue, 14 Jan 2020 17:05:20 -0500
Subject: [PATCH 3/3] fixup

---
 doc/api/net.md                                   | 2 +-
 test/parallel/test-net-server-max-connections.js | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/api/net.md b/doc/api/net.md
index 40a0720c3a58ac..6f585a328f5172 100644
--- a/doc/api/net.md
+++ b/doc/api/net.md
@@ -97,7 +97,7 @@ Emitted when a new connection is made. `socket` is an instance of
 added: REPLACEME
 -->
 
-Emitted when the server has reached his connection limit defined in [`server.maxConnections`][].
+Emitted when the server has reached its connection limit defined in [`server.maxConnections`][].
 
 ### Event: `'error'`
 <!-- YAML
diff --git a/test/parallel/test-net-server-max-connections.js b/test/parallel/test-net-server-max-connections.js
index a443789de48801..8881115d6814f0 100644
--- a/test/parallel/test-net-server-max-connections.js
+++ b/test/parallel/test-net-server-max-connections.js
@@ -44,7 +44,7 @@ server.listen(0, function() {
 
 server.maxConnections = N / 2;
 
-server.on('maxConnections', common.mustCall(N / 2));
+server.on('maxConnections', common.mustCall(server.maxConnections));
 
 function makeConnection(index) {
   const c = net.createConnection(server.address().port);