src: refactoring and cleanup of node_i18n #32438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
|
Can you add some high-level description in the OP or the commit message? I can see that there are some helper class added and class definition separated but not sure if they are meant to be copied verbatim or is there something else intended |
Done :-) |
addaleax
approved these changes
Mar 29, 2020
jasnell
added
the
author ready
Signed-off-by: James M Snell <jasnell@gmail.com>
joyeecheung
approved these changes
Mar 30, 2020
jasnell
added a commit
that referenced
this pull request
Mar 30, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32438 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Landed in accc984 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 31, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32438 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos
added
backport-blocked-v12.x
and removed
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#32438 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32438 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting some cleanup/refactoring of node_i18n
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes