Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: simplify and correct example descriptions in net.md #32451

Merged
merged 1 commit into from
Mar 26, 2020
Merged

doc: simplify and correct example descriptions in net.md #32451

merged 1 commit into from
Mar 26, 2020

Commits on Mar 26, 2020

  1. doc: simplify and correct example descriptions in net.md 

    Instead of indicating that examples show lines to change in previous
examples, present the examples as standalone items. They suffice on
their own.

In the first of these, it says to change "the second line" of a previous
example, but if it were literally changed to the provided line, it would
result in a syntax error.

In the second of these, it gives the wrong line to change.

All of this is unnecessary and probably makes the examples harder to
follow. So simplify and treat each one as a separate example.

PR-URL: nodejs#32451
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @Trott
    Trott committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    f0a33d9 View commit details
    Browse the repository at this point in the history