doc: make README(.md) more informative by indicating that a GPG key u… #32591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed to sign a release could be a sub-key of a key listed in README(.md) (which itself isn't listed in it) Update README.md. Fixes: nodejs#32559
haqer1
force-pushed
the
signing-key-fixup-alternative-approach-2
branch
from
bfe1ad9
to
c844885
Compare
haqer1
force-pushed
the
signing-key-fixup-alternative-approach-2
branch
from
5235d66
to
9949a61
Compare
…d to import a key used to sign a release & check whether it is a sub-key of a primary key listed in README(.md) (which itself isn't listed in it)... Addition README.md update Fixes: nodejs#32559
haqer1
force-pushed
the
signing-key-fixup-alternative-approach-2
branch
from
9949a61
to
fa68553
Compare
hassaanp
approved these changes
Apr 1, 2020
jasnell
approved these changes
Apr 2, 2020
MylesBorins
reviewed
Apr 3, 2020
There was a problem hiding this comment.
While I think it is reasonable to mention subkeys in this section I think the currently proposed copy could be more succinct.
I've made proposed an alternative but am also willing to review another iteration. Not blocking current copy, but I do think there is room for improvement.
This was referenced Apr 4, 2020
Co-Authored-By: Myles Borins <myles.borins@gmail.com>
Co-Authored-By: Myles Borins <myles.borins@gmail.com>
haqer1
force-pushed
the
signing-key-fixup-alternative-approach-2
branch
from
0e9ab47
to
333072c
Compare
|
Landed in ee5c836 |
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
PR-URL: nodejs#32591 Fixes: nodejs#32559 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sed to sign a release could be a sub-key of a key listed in README(.md) (which itself isn't listed in it)
Update README.md.
Fixes: #32559