Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-https-host-headers #32805

Closed
wants to merge 1 commit into from
Closed

test: refactor test-https-host-headers #32805

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

use common.mustCall and debuglog. remove Unnecessary function

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 13, 2020
@himself65
test: refactor test-https-host-headers
80acf58 
Use `common.mustCall` and `util.debuglog`. Remove unnecessary functions
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30674/

@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:18
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 16, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33682/

@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 16, 2020
@github-actions
Copy link
Contributor

Landed in aaf225a...a373130

@github-actions github-actions bot closed this Oct 16, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 16, 2020
@himself65 @nodejs-github-bot
test: refactor test-https-host-headers
a373130 
Use `common.mustCall` and `util.debuglog`. Remove unnecessary functions

PR-URL: #32805
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@himself65 @BethGriggs
test: refactor test-https-host-headers
d62e72b 
Use `common.mustCall` and `util.debuglog`. Remove unnecessary functions

PR-URL: #32805
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@himself65 @nodejs-github-bot @jasnell @aduh95