Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: cleanup and refactoring of http2 internals #32884

Closed
wants to merge 18 commits into from
Closed

http2: cleanup and refactoring of http2 internals #32884

wants to merge 18 commits into from

Commits on Apr 16, 2020

  1. http2: cleanup constants in http2 binding 

    The error constants were just doing some weird things. Cleanup
and improve maintainability.

Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    f38c9ea View commit details
    Browse the repository at this point in the history

  2. http2: refactor GetPackedSettings to avoid unnecessary AsyncWrap 

    Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    219e339 View commit details
    Browse the repository at this point in the history

  3. http2: simplify settings to reduce duplicate code 

    Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    5499c7c View commit details
    Browse the repository at this point in the history

  4. http2: improve style consistency and correctness 

    Use snake_case for getters and setters at c++ level,
avoid unnecessary use of enums,
use consistent style for exported vs. internal constants,
avoid unnecessary memory info reporting,
use setters/getters for flags_ for improved code readability

Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    dd06df1 View commit details
    Browse the repository at this point in the history

  5. http2: make EmitStatistics function private 

    Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    a2efaa7 View commit details
    Browse the repository at this point in the history

  6. http2: un-nest Http2Settings and Http2Ping 

    Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    b23cecc View commit details
    Browse the repository at this point in the history

  7. http2: refactoring and cleanup of Http2Settings and Http2Ping 

    Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    681bfe4 View commit details
    Browse the repository at this point in the history

  8. http2: avoid ** syntax for readability 

    The **session and **stream syntax for getting the underlying
nghttp2 pointers is not ideal for readability

Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    0e0a3a2 View commit details
    Browse the repository at this point in the history

  9. http2: avoid most uses to ToChecked/ToLocalChecked 

    Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    e39420f View commit details
    Browse the repository at this point in the history

  10. http2: use const references for Http2Priority 

    Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    e8a2f5e View commit details
    Browse the repository at this point in the history

  11. http2: remove unnecessary GetStream function 

    Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    52fcf89 View commit details
    Browse the repository at this point in the history

  12. http2: refactor Http2Scope to use BaseObjectPtr 

    Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    7aefc8f View commit details
    Browse the repository at this point in the history

  13. http2: move utility function to anonymous namespace 

    Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    d9c5a40 View commit details
    Browse the repository at this point in the history

  14. http2: refactor and simplify Origins 

    * Use an AllocatedBuffer instead of MaybeStackBuffer
* Use a const reference instead of pointer

Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    6b86554 View commit details
    Browse the repository at this point in the history

  15. http2: use BaseObjectPtr for Http2Streams map 

    Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    4ccd690 View commit details
    Browse the repository at this point in the history

  16. http2: move MemoryInfo impl to cc 

    Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    fe77e23 View commit details
    Browse the repository at this point in the history

  17. http2: fixup lint and style issues 

    Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    764c71d View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. [Squash] fixup

    @jasnell
    jasnell committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    1342b24 View commit details
    Browse the repository at this point in the history