Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: fix broken pipeline test #33030

Closed
wants to merge 1 commit into from
Closed

stream: fix broken pipeline test #33030

wants to merge 1 commit into from

Commits on Apr 23, 2020

  1. stream: fix broken pipeline test 

    An unfortunate overlap between two PR that by themselves pass
CI but together pass a test.

nodejs#32967 changes so that
pipeline does not wait for 'close'.

nodejs#32968 changed so that
all streams are not destroyed.

Which made one test fail when expected the stream to be
destroyed during pipeline callback.
    @ronag
    ronag committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    6080c94 View commit details
    Browse the repository at this point in the history