doc: update authors list #342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using tools/update-authors.sh
|
LGTM, Rod, but proper capitalization in commit logs, please. |
|
@bnoordhuis what are you referring to specifically here? |
|
The convention is to write full sentences in the commit log's body, i.e. "Update the AUTHORS file the using tools/update-authors.sh tool." instead of "using tools/update-authors.sh". (EDIT: Using proper grammar. There's an extra 'the' in my example. :-)) |
|
ahh, ok, noted, will try and remember this (forgive me if I lapse) |
rvagg
added a commit
that referenced
this pull request
Jan 13, 2015
Update AUTHORS file using tools/update-authors.sh PR-URL: #342 Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
|
landed in 2a790c0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using tools/update-authors.sh
We've added 10 additional authors in the 12 days since I last updated the file, I'd call that progress!