-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fix auto-start-ci script path #34588
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Jul 31, 2020
cc @nodejs/build |
Fast-track? Leave a 👍 if you agree |
mmarchini
added
the
fast-track
PRs that do not need to wait for 48 hours to land.
label
Jul 31, 2020
phillipj
approved these changes
Jul 31, 2020
Trott
approved these changes
Aug 1, 2020
Need one more approval and fast-track thumbs up |
richardlau
approved these changes
Aug 1, 2020
Landed in 849d9e7...9b6c16c |
mmarchini
added a commit
that referenced
this pull request
Aug 1, 2020
PR-URL: #34588 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
mmarchini
added a commit
that referenced
this pull request
Aug 1, 2020
PR-URL: #34588 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere
pushed a commit
that referenced
this pull request
Aug 5, 2020
PR-URL: #34588 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere
pushed a commit
that referenced
this pull request
Aug 5, 2020
PR-URL: #34588 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34588 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34588 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34588 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34588 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fast-track
PRs that do not need to wait for 48 hours to land.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed it while transfering the Action from the test repository to here. Also removed the push event since this should run only on schedule.