Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: enable build for node-v8 push #34634

Closed
wants to merge 1 commit into from
Closed

build: enable build for node-v8 push #34634

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Aug 5, 2020 •
edited
Loading

This mainly enable daily check for https://github.com/nodejs/node-v8.
This is pretty useful when talk to v8 team when build failure.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 5, 2020
@gengjiawen gengjiawen added the v8 engine Issues and PRs related to the V8 dependency. label Aug 5, 2020
@gengjiawen
Copy link
Member Author

Fast track ?

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 5, 2020
@gengjiawen gengjiawen mentioned this pull request Aug 5, 2020
Closed
gengjiawen added a commit that referenced this pull request Aug 6, 2020
@gengjiawen
build: enable build for node-v8 push
df17fcd 
PR-URL: #34634
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
@gengjiawen
Copy link
Member Author

Landed in df17fcd

@gengjiawen gengjiawen closed this Aug 6, 2020
addaleax pushed a commit that referenced this pull request Aug 8, 2020
@gengjiawen @addaleax
build: enable build for node-v8 push
9ed9ccc 
PR-URL: #34634
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
@codebytere codebytere mentioned this pull request Aug 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Aug 11, 2020
@gengjiawen @codebytere
build: enable build for node-v8 push
22f499f 
PR-URL: #34634
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@mmarchini mmarchini mmarchini approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gengjiawen @addaleax @mmarchini @richardlau @nodejs-github-bot