-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add common.mustSucceed #35086
Closed
Closed
test: add common.mustSucceed #35086
Commits on Oct 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ce9389a - Browse repository at this point
Copy the full SHA ce9389aView commit details -
Replaced the following pattern with "mustSucceed()": mustCall\([ \n]*(\(erro?r?\)[ \n]*=>[ \n]*\{?|function[ \n]*\(erro?r?\)[ \n]*\{)?[ \n]*assert\.ifError(\(erro?r?\))?;?[ \n]*\}?[ \n]*\)
Configuration menu - View commit details
-
Copy full SHA for 9c54c6b - Browse repository at this point
Copy the full SHA 9c54c6bView commit details -
Replaced the following pattern with "mustSucceed(($2)$3=>$4{\n": mustCall\([\n ]*\(erro?r?(,[\n ]*([^\)]*))?\)([\n ]*)=>([\n ]*)\{[\n ]+assert\.ifError\(erro?r?\);\n
Configuration menu - View commit details
-
Copy full SHA for 97b15e9 - Browse repository at this point
Copy the full SHA 97b15e9View commit details -
Replaced the following pattern with "mustSucceed(function($2)$3{\n": mustCall\([\n ]*function[ \n]*\(erro?r?(, *([^\)]*))?\)([ \t\n]*)\{[\n ]+assert\.ifError\(erro?r?\);\n
Configuration menu - View commit details
-
Copy full SHA for 4e7fbd8 - Browse repository at this point
Copy the full SHA 4e7fbd8View commit details -
Convert statements of the form assert(!err) to mustSucceed.
Configuration menu - View commit details
-
Copy full SHA for ea01060 - Browse repository at this point
Copy the full SHA ea01060View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b8676e - Browse repository at this point
Copy the full SHA 4b8676eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 476d930 - Browse repository at this point
Copy the full SHA 476d930View commit details -
Configuration menu - View commit details
-
Copy full SHA for c275bf0 - Browse repository at this point
Copy the full SHA c275bf0View commit details
Commits on Oct 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e43195b - Browse repository at this point
Copy the full SHA e43195bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.