From 1d5fa88eb808b7dfccc800fa1613a7ae15f06e8e Mon Sep 17 00:00:00 2001
From: Anna Henningsen <anna@addaleax.net>
Date: Sun, 4 Oct 2020 12:51:05 +0200
Subject: [PATCH] cli: add --node-memory-debug option

Add a public switch that turns on features for debugging memory
leaks inside of Node.js core.

PR-URL: https://github.com/nodejs/node/pull/35537
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
---
 doc/api/cli.md      | 9 +++++++++
 doc/node.1          | 4 ++++
 src/node_options.cc | 6 ++++++
 3 files changed, 19 insertions(+)

diff --git a/doc/api/cli.md b/doc/api/cli.md
index 7242c49351b978..9d4592b7c93f5c 100644
--- a/doc/api/cli.md
+++ b/doc/api/cli.md
@@ -546,6 +546,14 @@ added: v6.0.0
 
 Silence all process warnings (including deprecations).
 
+### `--node-memory-debug`
+<!-- YAML
+added: REPLACEME
+-->
+
+Enable extra debug checks for memory leaks in Node.js internals. This is
+usually only useful for developers debugging Node.js itself.
+
 ### `--openssl-config=file`
 <!-- YAML
 added: v6.9.0
@@ -1282,6 +1290,7 @@ Node.js options that are allowed are:
 * `--no-deprecation`
 * `--no-force-async-hooks-checks`
 * `--no-warnings`
+* `--node-memory-debug`
 * `--openssl-config`
 * `--pending-deprecation`
 * `--policy-integrity`
diff --git a/doc/node.1 b/doc/node.1
index f52014dbdcb9dc..63ee7391988e44 100644
--- a/doc/node.1
+++ b/doc/node.1
@@ -278,6 +278,10 @@ These will still be enabled dynamically when `async_hooks` is enabled.
 .It Fl -no-warnings
 Silence all process warnings (including deprecations).
 .
+.It Fl -node-memory-debug
+Enable extra debug checks for memory leaks in Node.js internals. This is
+usually only useful for developers debugging Node.js itself.
+.
 .It Fl -openssl-config Ns = Ns Ar file
 Load an OpenSSL configuration file on startup.
 Among other uses, this can be used to enable FIPS-compliant crypto if Node.js is built with
diff --git a/src/node_options.cc b/src/node_options.cc
index 9c3d74c85ca100..4fb4f455c47b00 100644
--- a/src/node_options.cc
+++ b/src/node_options.cc
@@ -762,6 +762,12 @@ PerProcessOptionsParser::PerProcessOptionsParser(
             kAllowedInEnvironment);
 
   Insert(iop, &PerProcessOptions::get_per_isolate_options);
+
+  AddOption("--node-memory-debug",
+            "Run with extra debug checks for memory leaks in Node.js itself",
+            NoOp{}, kAllowedInEnvironment);
+  Implies("--node-memory-debug", "--debug-arraybuffer-allocations");
+  Implies("--node-memory-debug", "--verify-base-objects");
 }
 
 inline std::string RemoveBrackets(const std::string& host) {