Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add a few uncovered url tests from wpt #35636

Closed
wants to merge 1 commit into from
Closed

test: add a few uncovered url tests from wpt #35636

wants to merge 1 commit into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Oct 14, 2020

Refs: web-platform-tests/wpt#25987

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@watilde watilde added test Issues and PRs related to the tests. dont-land-on-v14.x request-ci Add this label to start a Jenkins CI on a PR. labels Oct 14, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33603/

watilde added a commit that referenced this pull request Oct 16, 2020
@watilde
test: add a few uncovered url tests from wpt
c143266 
Refs: web-platform-tests/wpt#25987

PR-URL: #35636
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@watilde
Copy link
Member Author

watilde commented Oct 16, 2020

Landed in c143266

@watilde watilde closed this Oct 16, 2020
@watilde watilde deleted the wpt/url-update branch October 16, 2020 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@watilde @nodejs-github-bot @jasnell @Trott @lpinca @targos @joyeecheung