test: ignore asan new_delete_type_mismatch #35720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds ignore for new_delete_type_mismatch in EnvironmentTest as this is currently generating an error when address sanitizer is enabled and gcc is used as the compiler. This might be a little risky as we run the risk of missing other errors of this same type but I'm still looking into if this could be solved in some other way in V8 and perhaps this could be a short term fix. Fixes: nodejs#35669
jasnell
approved these changes
Oct 26, 2020
|
Closing, and will open a PR with a patch containing https://chromium-review.googlesource.com/c/v8/v8/+/2506712 after it lands in upstream V8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds ignore for new_delete_type_mismatch in EnvironmentTest
as this is currently generating an error when address sanitizer is
enabled and gcc is used as the compiler.
This might be a little risky as we run the risk of missing other errors
of this same type but I'm still looking into if this could be solved in
some other way in V8 and perhaps this could be a short term fix.
Fixes: #35669
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes