Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 3, 2021

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@aduh95 aduh95 added assert Issues and PRs related to the assert subsystem. needs-benchmark-ci PR that need a benchmark CI run. labels Jan 3, 2021
@aduh95

This comment has been minimized.

@mscdex

This comment has been minimized.

@aduh95

This comment has been minimized.

@aduh95

This comment has been minimized.

@aduh95 aduh95 removed the needs-benchmark-ci PR that need a benchmark CI run. label Jan 3, 2021
@aduh95

This comment has been minimized.

@aduh95 aduh95 added the needs-benchmark-ci PR that need a benchmark CI run. label Jan 3, 2021
@PoojaDurgad PoojaDurgad added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 4, 2021

These changes come with some perf regressions:

                                                   confidence improvement accuracy (*)    (**)   (***)
 assert/ok.js n=100000                                    ***     -6.77 %       ±3.69%  ±4.92%  ±6.44%
 assert/throws.js method='doesNotThrow' n=10000           ***    -14.90 %       ±5.67%  ±7.56%  ±9.86%

This may or may not be considered an acceptable trade-off.

@aduh95 aduh95 added review wanted PRs that need reviews. and removed needs-benchmark-ci PR that need a benchmark CI run. labels Jan 9, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 21, 2021

#37005 should help solve the perf issue.

EDIT: Nope, it doesn't help.

@aduh95 aduh95 added the blocked PRs that are blocked by other issues or PRs. label Jan 21, 2021
@aduh95 aduh95 removed the blocked PRs that are blocked by other issues or PRs. label Jan 28, 2021
@BridgeAR
Copy link
Member

I amgoing to close this due to the regressions and we didn't follow up anyway

@BridgeAR BridgeAR closed this Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assert Issues and PRs related to the assert subsystem. review wanted PRs that need reviews.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants