Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify child_process.exec inherits cwd #36809

Closed
wants to merge 1 commit into from
Closed

doc: clarify child_process.exec inherits cwd #36809

wants to merge 1 commit into from

Conversation

ugultopu
Copy link
Contributor

@ugultopu ugultopu commented Jan 6, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Jan 6, 2021
@yashLadha yashLadha added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 7, 2021
@jasnell
Copy link
Member

jasnell commented Jan 9, 2021

Landed in 6498e05

@jasnell jasnell closed this Jan 9, 2021
jasnell pushed a commit that referenced this pull request Jan 9, 2021
@ugultopu @jasnell
doc: clarify child_process.exec inherits cwd
6498e05 
PR-URL: #36809
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ugultopu ugultopu deleted the patch-1 branch January 10, 2021 23:15
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@ugultopu @danielleadams
doc: clarify child_process.exec inherits cwd
2d8423d 
PR-URL: #36809
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@ugultopu @targos
doc: clarify child_process.exec inherits cwd
57e27a3 
PR-URL: #36809
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

@yashLadha yashLadha yashLadha approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ugultopu @jasnell @addaleax @yashLadha @PoojaDurgad @nodejs-github-bot