doc: improve AsyncLocalStorage introduction #36946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
vdeturckheim
suggested changes
Jan 15, 2021
There was a problem hiding this comment.
Globally LGTM, @puzpuzpuz @Flarna @Qard maybe you want to take a look :)
puzpuzpuz
reviewed
Jan 15, 2021
puzpuzpuz
reviewed
Jan 15, 2021
puzpuzpuz
reviewed
Jan 15, 2021
Qard
requested changes
Jan 15, 2021
…se, or prone to misinterpretationtion
|
@vdeturckheim I rewrote and shorten the paragraph; I believe it resolves all issues. |
puzpuzpuz
reviewed
Jan 19, 2021
puzpuzpuz
approved these changes
Jan 19, 2021
Qard
reviewed
Jan 19, 2021
Qard
approved these changes
Jan 22, 2021
jasnell
approved these changes
Jan 25, 2021
|
Landed in 63d978c |
jasnell
pushed a commit
that referenced
this pull request
Jan 25, 2021
PR-URL: #36946 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 2, 2021
PR-URL: #36946 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #36946 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to comply to the contributing guidlines although I skimed over some of it; hopefully I didn't miss anything.