Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools,doc: add "legacy" badge in the TOC #37949

Closed
wants to merge 2 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 27, 2021

preview in light mode

preview in dark mode

This also fixes a bug when the stability index is the next sibling of the heading, currently the stability badge is shown in the TOC only if there's one or two nodes between the heading and the stability index (E.G.: in https://nodejs.org/api/crypto.html, Class: Certificate doesn't have a deprecated badge).

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Mar 27, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 28, 2021
tools/doc/html.js Outdated Show resolved Hide resolved
tools/doc/html.js Outdated Show resolved Hide resolved
Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 1, 2021

Landed in e8b1ea4

@jasnell jasnell closed this Apr 1, 2021
jasnell pushed a commit that referenced this pull request Apr 1, 2021
PR-URL: #37949
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 deleted the legacy-stability-index branch April 1, 2021 19:51
MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
PR-URL: #37949
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 4, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37949
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants