[v14.x] deps: V8 parent ordering fix backport #37973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
This comment has been minimized.
This comment has been minimized.
guybedford
force-pushed
the
v8-cycle-fix-backport-14
branch
2 times, most recently
from
b74b214
to
3537fff
Compare
guybedford
force-pushed
the
v8-cycle-fix-backport-14
branch
from
3537fff
to
16edc5c
Compare
This comment has been minimized.
This comment has been minimized.
guybedford
force-pushed
the
v8-cycle-fix-backport-14
branch
from
16edc5c
to
3c8169a
Compare
This comment has been minimized.
This comment has been minimized.
guybedford
force-pushed
the
v8-cycle-fix-backport-14
branch
from
3c8169a
to
3625f1e
Compare
This comment has been minimized.
This comment has been minimized.
guybedford
force-pushed
the
v8-cycle-fix-backport-14
branch
from
3625f1e
to
e15bf80
Compare
richardlau
approved these changes
Mar 31, 2021
common.gypi
Outdated
| @@ -36,7 +36,7 @@ | |||
|
|
|||
| # Reset this number to 0 on major V8 upgrades. | |||
| # Increment by one for each non-official patch applied to deps/v8. | |||
| 'v8_embedder_string': '-node.20', | |||
| 'v8_embedder_string': '-node.21', | |||
There was a problem hiding this comment.
Comment above says this should be incremented for each non-official patch, so probably each commit in this PR should bump the version up by one.
guybedford
force-pushed
the
v8-cycle-fix-backport-14
branch
from
e15bf80
to
1a12e2f
Compare
guybedford
changed the title
guybedford
force-pushed
the
v8-cycle-fix-backport-14
branch
from
1a12e2f
to
3940d74
Compare
MylesBorins
force-pushed
the
v14.x-staging
branch
from
11505ad
to
6b115d7
Compare
[torque] Move SourceTextModule flags definitions to Torque Refs: v8/v8@5f90cfd PR-URL: nodejs#37973 Reviewed-By: Richard Lau <rlau@redhat.com>
[top-level-await] Implement the new post-order requirement for async subgraphs Refs: v8/v8@f19142e PR-URL: nodejs#37864 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
guybedford
force-pushed
the
v8-cycle-fix-backport-14
branch
from
3940d74
to
04da72f
Compare
guybedford
added a commit
that referenced
this pull request
Apr 14, 2021
[torque] Move SourceTextModule flags definitions to Torque Refs: v8/v8@5f90cfd PR-URL: #37973 Reviewed-By: Richard Lau <rlau@redhat.com>
guybedford
added a commit
that referenced
this pull request
Apr 14, 2021
[top-level-await] Implement the new post-order requirement for async subgraphs Refs: v8/v8@f19142e PR-URL: #37864 Backport-PR-URL: #37973 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #37864 for 14.x. Getting this v8 patch to land cleanly required also porting v8/v8@5f90cfd which I've included as a separate commit in this PR.
This would be a very useful backport to ensure that between Node.js 14 and up, top-level await execution ordering semantics will always be well-defined and to specification.