Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node crashing due to endless loop #37757 #37990

Closed
wants to merge 14 commits into from
Closed

Fix node crashing due to endless loop #37757 #37990

wants to merge 14 commits into from

Commits on Apr 23, 2021

  1. test: ensure node doesnt crash with some selfsigned certificates 

    Refs: nodejs#37757
Refs: nodejs#37889
    @nils91
    nils91 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    0a3aa58 View commit details
    Browse the repository at this point in the history

  2. test: add empty line for readability

    @nils91
    nils91 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    00aca61 View commit details
    Browse the repository at this point in the history

  3. test: let server choose a port to use

    @nils91
    nils91 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    d4dd0b4 View commit details
    Browse the repository at this point in the history

  4. test: move https selfsigned to parallel

    @nils91
    nils91 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    832811d View commit details
    Browse the repository at this point in the history

  5. test: wrap callbacks in common.must[Not]Call

    @nils91
    nils91 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    5dca179 View commit details
    Browse the repository at this point in the history

  6. crypto: exit potentially infinite loop in GetLastIssuedCert if stuck 

    Fixes: nodejs#37757
Refs: nodejs#37889
    @nils91
    nils91 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    e3bd5f5 View commit details
    Browse the repository at this point in the history

  7. crypto: more compact solution to detect endless loop

    @nils91
    nils91 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    0734ad0 View commit details
    Browse the repository at this point in the history

  8. Revert "crypto: more compact solution to detect endless loop" 

    This reverts commit bd978e1.
    @nils91
    nils91 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    374335d View commit details
    Browse the repository at this point in the history

  9. crypto: put the condition at the very end of the loop

    @nils91
    nils91 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    fe0fcbb View commit details
    Browse the repository at this point in the history

  10. test: skip for OpenSSL<=1.1.1h

    @nils91
    nils91 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    b59150b View commit details
    Browse the repository at this point in the history

  11. test: remove unnecessary body from .mustNotCall

    @nils91
    nils91 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    b5b0c91 View commit details
    Browse the repository at this point in the history

  12. test: fix typo, '<' instead of '<='

    @nils91
    nils91 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    bb5bfde View commit details
    Browse the repository at this point in the history

  13. test: improve test readability 

    by moving key and cert as files to fixtures
    @nils91
    nils91 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    080ac2e View commit details
    Browse the repository at this point in the history

  14. test: skip test when openssl_is_fips

    @nils91
    nils91 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    a44ed4b View commit details
    Browse the repository at this point in the history