src: print arbitrary javascript exception value in node report #38009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
legendecas
force-pushed
the
node-report/exception
branch
from
68d2012 to
8292057
Compare
|
@legendecas is there any related issue or additional context? |
addaleax
reviewed
Mar 31, 2021
No, I didn't find any issues raised. Please checkout the tests included in the PR. Basically the issue is that node-report is unable to print those thrown primitives as uncaught exceptions. |
legendecas
force-pushed
the
node-report/exception
branch
2 times, most recently
from
86ae6c4 to
545cad3
Compare
This comment has been minimized.
This comment has been minimized.
|
@gireeshpunathil what do you think? |
jasnell
approved these changes
Apr 8, 2021
This comment has been minimized.
This comment has been minimized.
legendecas
force-pushed
the
node-report/exception
branch
from
545cad3 to
3504831
Compare
|
Just pushed with rebase and a fix on crash with |
This comment has been minimized.
This comment has been minimized.
legendecas
force-pushed
the
node-report/exception
branch
from
3504831 to
be59b67
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gireeshpunathil
approved these changes
Apr 20, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Looks like the CI failures are produced on pi2-docker, mostly "warning: failed to remove out/Release/.nfs00000000018426c4000015ac: Device or resource busy". And the history looks like the failure is happening to start from days ago. |
legendecas
added a commit
that referenced
this pull request
Apr 26, 2021
PR-URL: #38009 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
|
Landed in 55745a1 |
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
PR-URL: #38009 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
PR-URL: #38009 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any JavaScript values can be thrown and they have to be printed in node-report to prevent confusion.
This PR is trying to print primitive values' ToString value in the report as the
javascriptStack.message.