Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in buffer.md #38243

Merged
merged 1 commit into from
Apr 17, 2021
Merged

doc: fix typo in buffer.md #38243

merged 1 commit into from
Apr 17, 2021

Conversation

arkerone
Copy link
Contributor

I found a typo in buffer documentation :

alterered -> altered

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Apr 15, 2021
jasnell
jasnell approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast-track? Please 👍🏻

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 15, 2021
@jasnell
Copy link
Member

jasnell commented Apr 15, 2021

Unrelated github CI failure. Will land once we get a good run.

@marsonya marsonya added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 16, 2021
@arkerone @aduh95
doc: fix typo in buffer.md
fb93b71 
"alterered" ->  "altered"

PR-URL: nodejs#38243
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95 aduh95 force-pushed the doc/fix-typo-buffer branch from faf4e36 to fb93b71 Compare April 17, 2021 13:35
@aduh95
Copy link
Contributor

aduh95 commented Apr 17, 2021

Landed in fb93b71

@aduh95 aduh95 merged commit fb93b71 into nodejs:master Apr 17, 2021
@BethGriggs BethGriggs mentioned this pull request Apr 20, 2021
Merged
@arkerone arkerone deleted the doc/fix-typo-buffer branch April 21, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@marsonya marsonya marsonya approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.