src: refactor to use THROW_* argument based snprintf #38357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
tniessen
approved these changes
Apr 22, 2021
Collaborator
panva
force-pushed
the
refactor-throw-err
branch
from
06c018c to
e7c57e9
Compare
Collaborator
addaleax
approved these changes
Apr 22, 2021
Collaborator
jasnell
approved these changes
Apr 22, 2021
Collaborator
Collaborator
cjihrig
approved these changes
Apr 23, 2021
Collaborator
panva
added
author ready
Collaborator
Collaborator
panva
added a commit
that referenced
this pull request
Apr 24, 2021
PR-URL: #38357 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Landed in 04ec693 |
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
PR-URL: #38357 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #38354 this refactors various
src/node_errors.cc-based errors to use the argument based snprintf rather than explicitly building the message upfront.