Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove fixer for non-ascii-character ESLint custom rule #38413

Merged
merged 1 commit into from
Apr 28, 2021
Merged

tools: remove fixer for non-ascii-character ESLint custom rule #38413

merged 1 commit into from
Apr 28, 2021

Commits on Apr 28, 2021

  1. tools: remove fixer for non-ascii-character ESLint custom rule 

    The fixer for non-ascii-character does not typidally do the right thing.
It removes the entire node, not the offending character. I discovered
this when it removed the entire contents of a file and I wasn't sure
which auto-fix rule was doing it.

This commit adds a minimal test for the rule. The tests require that
auto-fix results be supplied, so if someone wants to re-add auto-fixing
to the rule, we'll have tests that it does the right thing.

PR-URL: nodejs#38413
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @Trott
    Trott committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    896e5af View commit details
    Browse the repository at this point in the history