test: call functions internally #38560
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All (or at least most) of the tests uses lambdas (or arrow functions if you will) to call these functions internally inside of directly calling them, this should also use this technique for consistency.
github-actions
bot
added
needs-ci
RaisinTen
approved these changes
May 5, 2021
jasnell
approved these changes
May 7, 2021
jasnell
added
author ready
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
Lxxyx
approved these changes
May 7, 2021
|
Landed in 29f1b60 |
jasnell
pushed a commit
that referenced
this pull request
May 7, 2021
All (or at least most) of the tests uses lambdas (or arrow functions if you will) to call these functions internally inside of directly calling them, this should also use this technique for consistency. PR-URL: #38560 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 17, 2021
All (or at least most) of the tests uses lambdas (or arrow functions if you will) to call these functions internally inside of directly calling them, this should also use this technique for consistency. PR-URL: #38560 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
All (or at least most) of the tests uses lambdas (or arrow functions if you will) to call these functions internally inside of directly calling them, this should also use this technique for consistency. PR-URL: #38560 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
All (or at least most) of the tests uses lambdas (or arrow functions if you will) to call these functions internally inside of directly calling them, this should also use this technique for consistency. PR-URL: #38560 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
All (or at least most) of the tests uses lambdas (or arrow functions if you will) to call these functions internally inside of directly calling them, this should also use this technique for consistency. PR-URL: #38560 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
All (or at least most) of the tests uses lambdas (or arrow functions if you will) to call these functions internally inside of directly calling them, this should also use this technique for consistency. PR-URL: #38560 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All (or at least most) of the tests uses lambdas (or arrow functions if you will) to call these functions internally inside of directly calling them, this should also use this technique for consistency.