Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: refactor to remove redundant argument of _deferToConnect #38598

Closed
wants to merge 1 commit into from
Closed

http: refactor to remove redundant argument of _deferToConnect #38598

wants to merge 1 commit into from

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented May 8, 2021 •
edited
Loading

Since it's considered a private method, I guess it's safe to remove this unused argument.

All references are here:

node/lib/_http_client.js

Lines 879 to 886 in 52e4fb5

ClientRequest.prototype.setNoDelay = function setNoDelay(noDelay) {
this._deferToConnect('setNoDelay', [noDelay]);
};
ClientRequest.prototype.setSocketKeepAlive =
function setSocketKeepAlive(enable, initialDelay) {
this._deferToConnect('setKeepAlive', [enable, initialDelay]);
};

@github-actions github-actions bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels May 8, 2021
@pd4d10 pd4d10 force-pushed the patch-http-client branch 2 times, most recently from 0e4595b to 8fd04b1 Compare May 8, 2021 09:48
@pd4d10 pd4d10 force-pushed the patch-http-client branch from 8fd04b1 to 0d37b0a Compare May 8, 2021 09:48
@mscdex mscdex added the needs-citgm PRs that need a CITGM CI run. label May 8, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37978/

@dnlup
Copy link
Contributor

dnlup commented May 8, 2021

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2688/

@Trott
Copy link
Member

Trott commented May 8, 2021

@nodejs/http

Trott
Trott approved these changes May 8, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CITGM doesn't find anything new outside of the usual expected set of errors/failures

@dnlup
Copy link
Contributor

dnlup commented May 8, 2021

Sorry, I misconfigured the previous citgm run.

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2689/

@dnlup
Copy link
Contributor

dnlup commented May 9, 2021

LGTM if CITGM doesn't find anything new outside of the usual expected set of errors/failures

We have some errors on hapi and fastify. I am not sure if they fall under that category.

@mcollina
Copy link
Member

I think it's just a flake on Fastify, I can't reproduce locally.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38078/

dnlup pushed a commit that referenced this pull request May 14, 2021
@pd4d10 @dnlup
http: refactor to remove redundant argument of _deferToConnect
a03d3af 
PR-URL: #38598
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@dnlup
Copy link
Contributor

dnlup commented May 14, 2021

Landed in a03d3af

Thank you @pd4d10

@dnlup dnlup closed this May 14, 2021
@pd4d10 pd4d10 deleted the patch-http-client branch May 15, 2021 02:20
targos pushed a commit that referenced this pull request May 17, 2021
@pd4d10 @targos
http: refactor to remove redundant argument of _deferToConnect
3d8b8e1 
PR-URL: #38598
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@pd4d10 @nodejs-github-bot @dnlup @Trott @mcollina @lpinca @aduh95 @mscdex @targos