fs: fix async iterator partial writes with writeFile #38615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix an issue where chunks might be partially written when using writeFile with an async iterator.
github-actions
bot
added
fs
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aduh95
reviewed
May 10, 2021
This comment has been minimized.
This comment has been minimized.
aduh95
approved these changes
May 12, 2021
Linkgoron
added
the
author ready
Trott
approved these changes
May 13, 2021
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
May 17, 2021
|
Landed in 3612229 |
jasnell
pushed a commit
that referenced
this pull request
May 17, 2021
fix an issue where chunks might be partially written when using writeFile with an async iterator. PR-URL: #38615 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 18, 2021
fix an issue where chunks might be partially written when using writeFile with an async iterator. PR-URL: #38615 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where chunks might be partially written when using
writeFilewith an async iterator.When writing a chunk it might only be partially written, as
writeis called without checking that everything was written - this fixes the issue. I've also added chunking to make the async iterator write match the regular write. There's a minor behaviour change, where previously strings would change to buffers in thec++layer, however that made checking if the buffer was completely written extremely difficult, so I've moved it to the JS side (which is what happens in the non-iterator path as well).