From 1efa8fe1aaf3c7bd827a70ffa414bc9e615e4ade Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 14 Jul 2021 06:19:22 -0700 Subject: [PATCH] doc: make minor edits to pull request text MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/39383 Reviewed-By: Michaël Zasso Reviewed-By: Richard Lau Reviewed-By: James M Snell Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig --- doc/guides/contributing/pull-requests.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 94c9bb69424cfd..d7ee55254f5506 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -116,8 +116,9 @@ repository includes changes to one or more of the following: * the documentation in `doc/api` * tests within the `test` directory. -If you are modifying code, please be sure to run `make lint` from time to -time to ensure that the changes follow the Node.js code style guide. +If you are modifying code, please be sure to run `make lint` (or +`vcbuild.bat lint` on Windows) to ensure that the changes follow the Node.js +code style guide. Any documentation you write (including code comments and API documentation) should follow the [Style Guide](../doc-style-guide.md). Code samples @@ -137,7 +138,7 @@ added: REPLACEME For contributing C++ code, you may want to look at the [C++ Style Guide](../cpp-style-guide.md), as well as the -[README of `src/`](../../../src/README.md) for an overview over Node.js +[README of `src/`](../../../src/README.md) for an overview of Node.js C++ internals. ### Step 4: Commit