Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: add some typings to internal/modules/esm/resolve #39504

Merged
merged 1 commit into from
Aug 2, 2021
Merged

module: add some typings to internal/modules/esm/resolve #39504

merged 1 commit into from
Aug 2, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 24, 2021

No description provided.

@aduh95 aduh95 added the typings label Jul 24, 2021
@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Jul 24, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jul 26, 2021
@targos
Copy link
Member

targos commented Aug 1, 2021

Nit: you can use the typings subsystem.

Mesteery
Mesteery reviewed Aug 1, 2021
View reviewed changes
Copy link
Contributor

@Mesteery Mesteery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

lib/internal/modules/esm/resolve.js Outdated Show resolved Hide resolved
lib/internal/modules/esm/resolve.js Outdated Show resolved Hide resolved
@aduh95
module: add some typings to internal/modules/esm/resolve
45f98fc 
PR-URL: nodejs#39504
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@aduh95 aduh95 force-pushed the fix-resolve-typings branch from e5fa661 to 45f98fc Compare August 2, 2021 08:22
@aduh95
Copy link
Contributor Author

aduh95 commented Aug 2, 2021

Nit: you can use the typings subsystem.

I tried and got ✖ 0:0 Invalid subsystem: "typings" subsystem upon landing.

@aduh95
Copy link
Contributor Author

aduh95 commented Aug 2, 2021

Landed in 45f98fc

@aduh95 aduh95 merged commit 45f98fc into nodejs:master Aug 2, 2021
@aduh95 aduh95 deleted the fix-resolve-typings branch August 2, 2021 08:23
@targos
Copy link
Member

targos commented Aug 2, 2021

Nit: you can use the typings subsystem.

I tried and got ✖ 0:0 Invalid subsystem: "typings" subsystem upon landing.

You probably have an outdated version of node-core-utils

danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@aduh95 @danielleadams
module: add some typings to internal/modules/esm/resolve
4df59bc 
PR-URL: #39504
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@danielleadams danielleadams mentioned this pull request Aug 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery left review comments

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @targos @jasnell @Mesteery @nodejs-github-bot