-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: remove unneeded .mailmap entry #39512
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous Perl script used to generate the AUTHORS file (probably) needed more entries than the current JS script to avoid duplicate entries in AUTHORS. The entry removed here is no longer needed for that purpose, but it is creating a small issue around tooling for gathering contributor metrics.
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Jul 25, 2021
Fast-track has been requested by @Trott. Please 👍 to approve. |
Trott
changed the title
meta: remove unneeded .mailmap entry that conflicts with README
meta: remove unneeded .mailmap entry
Jul 25, 2021
bmeck
approved these changes
Jul 25, 2021
tniessen
approved these changes
Jul 25, 2021
jasnell
approved these changes
Jul 26, 2021
Landed in c08a93f |
jasnell
pushed a commit
that referenced
this pull request
Jul 26, 2021
The previous Perl script used to generate the AUTHORS file (probably) needed more entries than the current JS script to avoid duplicate entries in AUTHORS. The entry removed here is no longer needed for that purpose, but it is creating a small issue around tooling for gathering contributor metrics. PR-URL: #39512 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Jul 26, 2021
The previous Perl script used to generate the AUTHORS file (probably) needed more entries than the current JS script to avoid duplicate entries in AUTHORS. The entry removed here is no longer needed for that purpose, but it is creating a small issue around tooling for gathering contributor metrics. PR-URL: #39512 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Jul 29, 2021
The previous Perl script used to generate the AUTHORS file (probably) needed more entries than the current JS script to avoid duplicate entries in AUTHORS. The entry removed here is no longer needed for that purpose, but it is creating a small issue around tooling for gathering contributor metrics. PR-URL: #39512 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Jul 29, 2021
The previous Perl script used to generate the AUTHORS file (probably) needed more entries than the current JS script to avoid duplicate entries in AUTHORS. The entry removed here is no longer needed for that purpose, but it is creating a small issue around tooling for gathering contributor metrics. PR-URL: #39512 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Jul 29, 2021
The previous Perl script used to generate the AUTHORS file (probably) needed more entries than the current JS script to avoid duplicate entries in AUTHORS. The entry removed here is no longer needed for that purpose, but it is creating a small issue around tooling for gathering contributor metrics. PR-URL: #39512 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
The previous Perl script used to generate the AUTHORS file (probably) needed more entries than the current JS script to avoid duplicate entries in AUTHORS. The entry removed here is no longer needed for that purpose, but it is creating a small issue around tooling for gathering contributor metrics. PR-URL: #39512 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fast-track
PRs that do not need to wait for 48 hours to land.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous Perl script used to generate the AUTHORS file (probably)
needed more entries than the current JS script to avoid duplicate
entries in AUTHORS. The entry removed here is no longer needed for that
purpose, but it is creating a small issue around tooling for gathering
contributor metrics.