Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: consolidate AUTHORS entries for mithunsasidharan #40003

Closed
wants to merge 1 commit into from
Closed

meta: consolidate AUTHORS entries for mithunsasidharan #40003

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 5, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 5, 2021
@Trott
Copy link
Member Author

Trott commented Sep 5, 2021

@mithunsasidharan This merges your two AUTHORS entries (same name, two different email addresses) into one. If you'd prefer we keep the paypal.com email address instead of the gmail.com address, please leave a comment. Thanks!

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2021

Fast-track has been requested by @jasnell. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2021

Landed in 3e774a0...8d5ed10

@github-actions github-actions bot closed this Sep 7, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 7, 2021
@Trott @nodejs-github-bot
meta: consolidate AUTHORS entries for mithunsasidharan
8d5ed10 
PR-URL: #40003
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@Trott @BethGriggs
meta: consolidate AUTHORS entries for mithunsasidharan
29104f5 
PR-URL: #40003
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
@Trott Trott deleted the ms-mailmap branch September 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @jasnell @lpinca @targos @nodejs-github-bot