Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-dgram-udp6-link-local-address on Windows #40005

Closed
wants to merge 1 commit into from
Closed

test: fix test-dgram-udp6-link-local-address on Windows #40005

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 5, 2021

This fixes the test on my machine at least.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 5, 2021
@targos targos added dgram Issues and PRs related to the dgram subsystem / UDP. windows Issues and PRs related to the Windows platform. and removed needs-ci PRs that need a full CI run. labels Sep 5, 2021
@targos
Copy link
Member Author

targos commented Sep 5, 2021

Error was:

node .\test\parallel\test-dgram-udp6-link-local-address.js
node:events:371
      throw er; // Unhandled 'error' event
      ^

Error: getaddrinfo ENOTFOUND fe80::a030:196b:d025:69fb%vEthernet (Ethernet 2)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:71:26)
Emitted 'error' event on Socket instance at:
    at GetAddrInfoReqWrap.callback (node:dgram:326:12)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:71:17) {
  errno: -3008,
  code: 'ENOTFOUND',
  syscall: 'getaddrinfo',
  hostname: 'fe80::a030:196b:d025:69fb%vEthernet (Ethernet 2)'
}

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39794/

@jasnell
Copy link
Member

jasnell commented Sep 5, 2021

Bunch of relevant failures in CI

@targos
Copy link
Member Author

targos commented Sep 5, 2021

At least it passed on Windows 😄

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39800/

@targos
Copy link
Member Author

targos commented Sep 6, 2021

It's fixed.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39825/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39839/

@targos targos added the review wanted PRs that need reviews. label Sep 7, 2021
@targos
Copy link
Member Author

targos commented Sep 18, 2021

ping @nodejs/testing @jasnell

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2021
@github-actions
Copy link
Contributor

Landed in 420cdc7...4e7fe5a

@github-actions github-actions bot closed this Sep 20, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 20, 2021
@targos @nodejs-github-bot
test: fix test-dgram-udp6-link-local-address on Windows
4e7fe5a 
PR-URL: #40005
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos deleted the fix-test-udp-win branch September 20, 2021 14:11
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@targos @BethGriggs
test: fix test-dgram-udp6-link-local-address on Windows
7029db2 
PR-URL: #40005
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@targos @BethGriggs
test: fix test-dgram-udp6-link-local-address on Windows
6be405b 
PR-URL: #40005
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. review wanted PRs that need reviews. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @nodejs-github-bot @jasnell @Trott