Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix list indentation in corepack.md #40029

Closed
wants to merge 1 commit into from
Closed

doc: fix list indentation in corepack.md #40029

wants to merge 1 commit into from

Conversation

alexeyten
Copy link
Contributor

Fix list indentation

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 7, 2021
@alexeyten alexeyten changed the title Update corepack.md doc: fix list indentation in corepack.md Sep 7, 2021
@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2021

Fast-track has been requested by @aduh95. Please 👍 to approve.

tniessen
tniessen approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, @alexeyten!

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 7, 2021
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2021

Landed in 5d34ef5...861c3e0

@github-actions github-actions bot closed this Sep 7, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 7, 2021
@alexeyten @nodejs-github-bot
doc: fix list indentation in corepack.md
861c3e0 
PR-URL: #40029
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@alexeyten alexeyten deleted the patch-1 branch September 8, 2021 07:26
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@alexeyten @BethGriggs
doc: fix list indentation in corepack.md
846e7e8 
PR-URL: #40029
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@Leko Leko Leko approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alexeyten @jasnell @Leko @lpinca @tniessen @aduh95 @nodejs-github-bot