meta: add mailmap entry for ralphtheninja #40153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
lpinca
approved these changes
Sep 20, 2021
Trott
added
the
author ready
Lxxyx
approved these changes
Sep 23, 2021
Trott
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/40153 ✔ Done loading data for nodejs/node/pull/40153 ----------------------------------- PR info ------------------------------------ Title meta: add mailmap entry for ralphtheninja (#40153) Author Rich Trott (@Trott) Branch Trott:mailmap-rtn -> nodejs:master Labels meta, author ready Commits 1 - meta: add mailmap entry for ralphtheninja Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40153 Reviewed-By: Luigi Pinca Reviewed-By: Zijian Liu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40153 Reviewed-By: Luigi Pinca Reviewed-By: Zijian Liu -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 19 Sep 2021 15:18:13 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40153#pullrequestreview-758993146 ✔ - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/40153#pullrequestreview-762205663 ⚠ This PR has conflicts that must be resolved ✔ Last GitHub Actions successful ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1266702421 |
Trott
added
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/40153 ✔ Done loading data for nodejs/node/pull/40153 ----------------------------------- PR info ------------------------------------ Title meta: add mailmap entry for ralphtheninja (#40153) Author Rich Trott (@Trott) Branch Trott:mailmap-rtn -> nodejs:master Labels meta, author ready Commits 1 - meta: add mailmap entry for ralphtheninja Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40153 Reviewed-By: Luigi Pinca Reviewed-By: Zijian Liu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40153 Reviewed-By: Luigi Pinca Reviewed-By: Zijian Liu -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - meta: add mailmap entry for ralphtheninja ℹ This PR was created on Sun, 19 Sep 2021 15:18:13 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40153#pullrequestreview-758993146 ✔ - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/40153#pullrequestreview-762205663 ✔ Last GitHub Actions successful ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1267994654 |
PR-URL: nodejs#40153 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
|
Landed in 8e84d56 |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
PR-URL: #40153 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.