src: ensure V8 initialized before marking milestone #40405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
nodejs-github-bot
added
c++
addaleax
approved these changes
Oct 11, 2021
cjihrig
approved these changes
Oct 11, 2021
joyeecheung
approved these changes
Oct 12, 2021
Mesteery
added
request-ci
github-actions
bot
removed
the
request-ci
Mesteery
added
the
author ready
22 tasks
RaisinTen
reviewed
Oct 14, 2021
|
|
||
| if (per_process::v8_initialized) { | ||
| performance_state_->Mark(performance::NODE_PERFORMANCE_MILESTONE_V8_START, | ||
| performance::performance_v8_start); |
There was a problem hiding this comment.
Suggested change
| performance::performance_v8_start); | |
| performance::performance_v8_start); |
nit: we can align these vertically
23 tasks
|
Landed in ad4e70c |
codebytere
added a commit
that referenced
this pull request
Oct 15, 2021
PR-URL: #40405 Refs: electron/electron#31349 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This was referenced Oct 16, 2021
2 tasks
25 tasks
targos
pushed a commit
that referenced
this pull request
Nov 4, 2021
PR-URL: #40405 Refs: electron/electron#31349 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs:
When Node.js is started within Electron's environment it doesn't initialize V8, so V8's start time is never set. As a result, Electron logs V8's start time as 0 and it breaks timestamps in the trace log.
This change fixes the issue by adding logic to log V8's start time only when V8 is initialized by Node.js.