Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: make validateAbortSignal stricter #40657

Closed

Commits on Oct 30, 2021

  1. lib: make validateAbortSignal stricter

    We should not force-check if the passed signal is **NOT** undefined
    and then proceed to check whether the value is an abort signal or not
    as the validator won't throw an error if the value is undefined as we
    straight up validate the values instead of checking if they're not
    undefined first. This unnecessary check can be done explicitly outside
    of the validator to only pass the value to the validator if its not
    undefined.
    VoltrexKeyva committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    0cf6999 View commit details
    Browse the repository at this point in the history