Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: Prevent Buffer constructor deopt #4158

Closed
wants to merge 1 commit into from
Closed

buffer: Prevent Buffer constructor deopt #4158

wants to merge 1 commit into from

Commits on Dec 4, 2015

  1. buffer: Prevent Buffer constructor deopt 

    The Buffer constructor will generally get inlined, but any call to the Buffer
constructor for a string without encoding will cause an eager deoptimization
of any function that inlined the Buffer constructor. This is due to a an
out-of-bounds read on `arguments[1]`. This change prevents that deopt.
    @brycebaril
    brycebaril committed Dec 4, 2015
    Configuration menu
    Copy the full SHA
    13d7b06 View commit details
    Browse the repository at this point in the history