Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add v16 changelog link to iojs changelog #41808

Conversation

danielleadams
Copy link
Contributor

@danielleadams danielleadams commented Feb 1, 2022

Adds missing v16 Changelog link to the old iojs Changelog.

@nodejs-github-bot nodejs-github-bot added the release Issues and PRs related to Node.js releases. label Feb 1, 2022
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/41808
✔  Done loading data for nodejs/node/pull/41808
----------------------------------- PR info ------------------------------------
Title      doc: add v16 changelog link to iojs changelog (#41808)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     danielleadams:da/add-missing-changelog-to-iojs -> nodejs:master
Labels     doc, fast-track, author ready, release
Commits    1
 - doc: add v16 changelog link to iojs changelog
Committers 1
 - Danielle Adams 
PR-URL: https://github.com/nodejs/node/pull/41808
Reviewed-By: Richard Lau 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Mestery 
Reviewed-By: Colin Ihrig 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41808
Reviewed-By: Richard Lau 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Mestery 
Reviewed-By: Colin Ihrig 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 01 Feb 2022 13:21:36 GMT
   ✔  Approvals: 4
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41808#pullrequestreview-869129863
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41808#pullrequestreview-869131523
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41808#pullrequestreview-869147766
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41808#pullrequestreview-869151975
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1778699719

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Feb 1, 2022
@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 1, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2022
@nodejs-github-bot nodejs-github-bot merged commit 7904331 into nodejs:master Feb 1, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 7904331

ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
PR-URL: #41808
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
danielleadams added a commit that referenced this pull request Mar 2, 2022
PR-URL: #41808
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
danielleadams added a commit that referenced this pull request Mar 3, 2022
PR-URL: #41808
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@danielleadams danielleadams deleted the da/add-missing-changelog-to-iojs branch March 4, 2022 14:29
danielleadams added a commit that referenced this pull request Mar 14, 2022
PR-URL: #41808
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants