-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootstrap: support configure-time user-land snapshot #42466
Closed
Closed
Commits on Mar 25, 2022
-
bootstrap: refresh options in pre-execution
Refresh the options map during pre-execution to pave the way for user land snapshots which may need to access run-time options at snapshot-building time. The default embedded bootstrap snapshot is still prevented from accessing them at snapshot building time since it serves a wider audience and is ignorant of application states, while the user-land snapshots are meant to be application-specific and so it makes sense for them to access runtime states as long as the snapshotted-code works with re-initialized runtime states.
Configuration menu - View commit details
-
Copy full SHA for 208d047 - Browse repository at this point
Copy the full SHA 208d047View commit details -
build: add --node-snapshot-main configure option
This adds a --build-snapshot runtime option which is currently only supported by the node_mksnapshot binary, and a --node-snapshot-main configure option that makes use it to run a custom script when building the embedded snapshot. The idea is to have this experimental feature in core as a configure-time feature for now, and investigate the renaming V8 bugs before we make it available to more users via making it a runtime option.
Configuration menu - View commit details
-
Copy full SHA for 4d59a74 - Browse repository at this point
Copy the full SHA 4d59a74View commit details -
bootstrap: make I/O streams work with user-land snapshot
Use the mksnapshot cleanup hooks to release the references to the native streams so that they can be destroyed right before the snapshot is taken, and move the initialization of the global console to pre-execution so that they can be re-initialized during snapshot dehydration. This makes it possible for user-land snapshots to use the I/O during snapshot building.
Configuration menu - View commit details
-
Copy full SHA for c812b98 - Browse repository at this point
Copy the full SHA c812b98View commit details -
bootstrap: run inspector and event loop in snapshot builder
This makes --inspect and stdin/out functional in the embedded snapshot, currently it's not guaranteed that these work perfectly, the plan is to investigate any out-of-sync states that might appear in user land snapshots with this while the it is a configure-time feature.
Configuration menu - View commit details
-
Copy full SHA for 39cd563 - Browse repository at this point
Copy the full SHA 39cd563View commit details
Commits on Mar 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for da8c19f - Browse repository at this point
Copy the full SHA da8c19fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1f934f - Browse repository at this point
Copy the full SHA b1f934fView commit details
Commits on Mar 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4d0500d - Browse repository at this point
Copy the full SHA 4d0500dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 25f4c8d - Browse repository at this point
Copy the full SHA 25f4c8dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.