From ec46a75ccabb2be32ace3236fc82380cf35b01cd Mon Sep 17 00:00:00 2001
From: Shogun <paolo@cowtech.it>
Date: Wed, 6 Apr 2022 11:41:00 +0200
Subject: [PATCH 1/2] doc: add note about header values encoding

---
 doc/api/http.md | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/doc/api/http.md b/doc/api/http.md
index dd8c90d79a3404..9adcba7b17039d 100644
--- a/doc/api/http.md
+++ b/doc/api/http.md
@@ -987,6 +987,17 @@ or
 request.setHeader('Cookie', ['type=ninja', 'language=javascript']);
 ```
 
+When the value is a string an exception will be thrown if it contains
+characters outside the `latin1` encoding.
+
+If you need to pass UTF-8 characters in the value please encode the value
+using the [RFC 8187][] standard.
+
+```js
+const filename = 'Rock 🎵.txt';
+request.setHeader('Content-Disposition', `inline; filename*=utf-8''${encodeURIComponent(filename)}`);
+```
+
 ### `request.setNoDelay([noDelay])`
 
 <!-- YAML
@@ -3406,6 +3417,7 @@ try {
 }
 ```
 
+[RFC 8187]: https://www.rfc-editor.org/rfc/rfc8187.txt
 [`'checkContinue'`]: #event-checkcontinue
 [`'finish'`]: #event-finish
 [`'request'`]: #event-request

From 5518dfe5449738ae7b7eb62283c5b1ffafd26773 Mon Sep 17 00:00:00 2001
From: Paolo Insogna <paolo@cowtech.it>
Date: Wed, 6 Apr 2022 16:13:35 +0200
Subject: [PATCH 2/2] doc: use better example

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
---
 doc/api/http.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/api/http.md b/doc/api/http.md
index 9adcba7b17039d..e8077785b8546c 100644
--- a/doc/api/http.md
+++ b/doc/api/http.md
@@ -995,7 +995,7 @@ using the [RFC 8187][] standard.
 
 ```js
 const filename = 'Rock 🎵.txt';
-request.setHeader('Content-Disposition', `inline; filename*=utf-8''${encodeURIComponent(filename)}`);
+request.setHeader('Content-Disposition', `attachment; filename*=utf-8''${encodeURIComponent(filename)}`);
 ```
 
 ### `request.setNoDelay([noDelay])`