From eb5b2866454253f8f183f2e2dec605af1851c0a5 Mon Sep 17 00:00:00 2001 From: DeeDeeG Date: Mon, 9 May 2022 21:43:53 -0400 Subject: [PATCH 1/3] doc: remove outdated footnote (Python 2 --> 3 for V8 tests) Various Python 3 compatibility fixes were made in upstream V8, and they have even dropped Python 2 compatibility in various scripts. depot_tools, which bootstraps the V8 build, is also moving to Python 3. As of Node v18.0.0-ish, this footnote is no-longer accurate. (Running `make test-v8` no-longer requires Python 2, and it won't work anymore if you don't have a copy of Python 3.) --- doc/contributing/maintaining-V8.md | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/doc/contributing/maintaining-V8.md b/doc/contributing/maintaining-V8.md index 339cda49488600..04cbe726268225 100644 --- a/doc/contributing/maintaining-V8.md +++ b/doc/contributing/maintaining-V8.md @@ -222,7 +222,7 @@ to be cherry-picked in the Node.js repository and V8-CI must test the change. * Run the Node.js [V8 CI][] in addition to the [Node.js CI][]. The CI uses the `test-v8` target in the `Makefile`, which uses `tools/make-v8.sh` to reconstruct a git tree in the `deps/v8` directory to - run V8 tests.[^2] + run V8 tests. The [`git-node`][] tool can be used to simplify this task. Run `git node v8 backport ` to cherry-pick a commit. @@ -407,11 +407,6 @@ This would require some tooling to: [^1]: Node.js 0.12 and older are intentionally omitted from this document as their support has ended. -[^2]: The V8 tests still require Python 2. To run these tests locally, you can - run `PYTHON2 ./configure.py` before running `make test-v8`, in the root - of this repository. On macOS, this also requires a full Xcode install, - not just the "command line tools" for Xcode. - [ChromiumReleaseCalendar]: https://www.chromium.org/developers/calendar [Node.js CI]: https://ci.nodejs.org/job/node-test-pull-request/ [Node.js `canary` branch]: https://github.com/nodejs/node-v8/tree/canary From 4ca2ca654b4e4a16087406f88fdc8ce090c1c180 Mon Sep 17 00:00:00 2001 From: DeeDeeG Date: Sat, 14 May 2022 19:08:52 -0400 Subject: [PATCH 2/3] doc: restore the macOS-only note about needing full Xcode for V8 tests Restore unintentionally deleted bit of the footnote. (I haven't checked whether just the "command line tools" are enough now. So it's safer to assume this part of the footnote is still accurate, than to assume the requirements have changed.) --- doc/contributing/maintaining-V8.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-V8.md b/doc/contributing/maintaining-V8.md index 04cbe726268225..fc0b2c46f99fa0 100644 --- a/doc/contributing/maintaining-V8.md +++ b/doc/contributing/maintaining-V8.md @@ -222,7 +222,7 @@ to be cherry-picked in the Node.js repository and V8-CI must test the change. * Run the Node.js [V8 CI][] in addition to the [Node.js CI][]. The CI uses the `test-v8` target in the `Makefile`, which uses `tools/make-v8.sh` to reconstruct a git tree in the `deps/v8` directory to - run V8 tests. + run V8 tests.[^2] The [`git-node`][] tool can be used to simplify this task. Run `git node v8 backport ` to cherry-pick a commit. @@ -407,6 +407,9 @@ This would require some tooling to: [^1]: Node.js 0.12 and older are intentionally omitted from this document as their support has ended. +[^2]: On macOS, The V8 tests require a full Xcode install, not just the "command + line tools" for Xcode. + [ChromiumReleaseCalendar]: https://www.chromium.org/developers/calendar [Node.js CI]: https://ci.nodejs.org/job/node-test-pull-request/ [Node.js `canary` branch]: https://github.com/nodejs/node-v8/tree/canary From 6f44a84277a86edc137743f997c910d66c0cf8ea Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 15 May 2022 06:27:23 -0700 Subject: [PATCH 3/3] Update doc/contributing/maintaining-V8.md --- doc/contributing/maintaining-V8.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-V8.md b/doc/contributing/maintaining-V8.md index fc0b2c46f99fa0..466e19b38bfb77 100644 --- a/doc/contributing/maintaining-V8.md +++ b/doc/contributing/maintaining-V8.md @@ -407,7 +407,7 @@ This would require some tooling to: [^1]: Node.js 0.12 and older are intentionally omitted from this document as their support has ended. -[^2]: On macOS, The V8 tests require a full Xcode install, not just the "command +[^2]: On macOS, the V8 tests require a full Xcode install, not just the "command line tools" for Xcode. [ChromiumReleaseCalendar]: https://www.chromium.org/developers/calendar