Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use serial comma in events docs #43113

Merged
merged 1 commit into from
May 15, 2022
Merged

doc: use serial comma in events docs #43113

merged 1 commit into from
May 15, 2022

Conversation

tniessen
Copy link
Member

node/doc/README.md

Line 21 in 5e9274a

* [Use serial commas][].

Refs: #11321
Refs: #17384

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label May 15, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels May 15, 2022
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 15, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 15, 2022
@nodejs-github-bot nodejs-github-bot merged commit 82861e9 into nodejs:master May 15, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 82861e9

BethGriggs pushed a commit that referenced this pull request May 16, 2022
@tniessen @BethGriggs
doc: use serial comma in events docs
839824a 
Refs: #11321
Refs: #17384

PR-URL: #43113
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@RafaelGSS RafaelGSS mentioned this pull request May 16, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@tniessen @juanarbol
doc: use serial comma in events docs
ec10ae7 
Refs: #11321
Refs: #17384

PR-URL: #43113
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@tniessen @danielleadams
doc: use serial comma in events docs
16acc17 
Refs: #11321
Refs: #17384

PR-URL: #43113
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
targos pushed a commit that referenced this pull request Jul 12, 2022
@tniessen @targos
doc: use serial comma in events docs
d750160 
Refs: #11321
Refs: #17384

PR-URL: #43113
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
targos pushed a commit that referenced this pull request Jul 31, 2022
@tniessen @targos
doc: use serial comma in events docs
cccc456 
Refs: #11321
Refs: #17384

PR-URL: #43113
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@tniessen @guangwong
doc: use serial comma in events docs
3d6e8e5 
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43113
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tniessen @nodejs-github-bot @Trott @RaisinTen @LiviaMedeiros