Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update main branch name in doc/contributing/* #43438

Merged
merged 2 commits into from
Jun 16, 2022
Merged

doc: update main branch name in doc/contributing/* #43438

merged 2 commits into from
Jun 16, 2022

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jun 15, 2022

Refs: #33864

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 15, 2022
aduh95
aduh95 approved these changes Jun 15, 2022
View reviewed changes
doc/contributing/backporting-to-release-lines.md Outdated Show resolved Hide resolved
doc/contributing/collaborator-guide.md Outdated Show resolved Hide resolved
doc/contributing/collaborator-guide.md Outdated Show resolved Hide resolved
doc/contributing/collaborator-guide.md Outdated Show resolved Hide resolved
doc/contributing/collaborator-guide.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-V8.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-V8.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-openssl.md Outdated Show resolved Hide resolved
doc/contributing/writing-and-running-benchmarks.md Outdated Show resolved Hide resolved
doc/contributing/writing-tests.md Outdated Show resolved Hide resolved
@lpinca @aduh95
Apply suggestions from code review
31f38f6 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 15, 2022
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 16, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 16, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 16, 2022
@nodejs-github-bot nodejs-github-bot merged commit 7bf50bc into nodejs:main Jun 16, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 7bf50bc

@lpinca lpinca deleted the update/main-branch-name branch June 16, 2022 14:10
targos pushed a commit that referenced this pull request Jul 12, 2022
@lpinca @targos
doc: update main branch name in doc/contributing/*
429e0f4 
Refs: #33864

PR-URL: #43438
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 18, 2022
@lpinca @targos
doc: update main branch name in doc/contributing/*
2fafd52 
Refs: #33864

PR-URL: #43438
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@lpinca @targos
doc: update main branch name in doc/contributing/*
d5832e2 
Refs: #33864

PR-URL: #43438
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@lpinca @guangwong
doc: update main branch name in doc/contributing/*
9703ff6 
Refs: nodejs/node#33864

PR-URL: nodejs/node#43438
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@aduh95 aduh95 aduh95 approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@danielleadams danielleadams danielleadams approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@lpinca @nodejs-github-bot @Trott @tniessen @richardlau @danielleadams @gireeshpunathil @aduh95 @RaisinTen @LiviaMedeiros