tools: remove rpm build scripts #43647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added these in 2013 but I don't think anyone uses them and I'm not even sure they still produce a working package. I move to remove them because that makes subsequent cleanup a little easier.
targos
approved these changes
Jul 1, 2022
lpinca
approved these changes
Jul 1, 2022
richardlau
approved these changes
Jul 1, 2022
VoltrexKeyva
approved these changes
Jul 2, 2022
tniessen
approved these changes
Jul 2, 2022
cjihrig
approved these changes
Jul 3, 2022
gengjiawen
approved these changes
Jul 4, 2022
juanarbol
approved these changes
Jul 4, 2022
There was a problem hiding this comment.
LGTM. But I would like to consider that this may explode NodeSource's rpm distributions; would you mind if I reach NodeSource distributions first (before landing this)? AFAIK, lots of people use it to install Node.js; this could potentially affect lots of people
|
@juanarbol Sure, go ahead. I believe @rvagg once mentioned you don't but that was years ago. |
|
Thank you @juanarbol for asking us. @bnoordhuis is right, we don't use these files anymore. They can be removed without affecting us. |
|
|
|
Do this needs CI? |
|
Nope, nothing tests it. |
bnoordhuis
added
request-ci
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7a0164a |
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
I added these in 2013 but I don't think anyone uses them and I'm not even sure they still produce a working package. I move to remove them because that makes subsequent cleanup a little easier. PR-URL: #43647 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2022
I added these in 2013 but I don't think anyone uses them and I'm not even sure they still produce a working package. I move to remove them because that makes subsequent cleanup a little easier. PR-URL: #43647 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
I added these in 2013 but I don't think anyone uses them and I'm not even sure they still produce a working package. I move to remove them because that makes subsequent cleanup a little easier. PR-URL: #43647 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
I added these in 2013 but I don't think anyone uses them and I'm not even sure they still produce a working package. I move to remove them because that makes subsequent cleanup a little easier. PR-URL: nodejs/node#43647 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added these in 2013 but I don't think anyone uses them and I'm not
even sure they still produce a working package.
I move to remove them because that makes subsequent cleanup a little
easier.